[TAS-954] 🩹 Increase gas multiplier for updating ISCN #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AuroraHuang22
changed the title
williamchong
requested changes
Jan 26, 2024
utils/cosmos/iscn/sign.ts
Outdated
| @@ -159,7 +159,7 @@ export async function signISCN( | |||
| { | |||
| iscnId, | |||
| memo, | |||
| gas = new BigNumber(ISCN_GAS_FEE).multipliedBy(ISCN_GAS_MULTIPLIER).toFixed(0), | |||
| gas = new BigNumber(ISCN_GAS_FEE).multipliedBy(UPDATE_ISCN_GAS_MULTIPLIER).toFixed(0), | |||
There was a problem hiding this comment.
How about set a gas when calling signISCN when we update ISCN?
There was a problem hiding this comment.
AuroraHuang22
force-pushed
the
feature/gas-fee
branch
from
2c529a1
to
e27c11e
Compare
AuroraHuang22
added a commit
that referenced
this pull request
Jan 31, 2024
williamchong
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the multiplier has been used and iscn-js updated, the wanted gas fee for updating ISCN is still slightly insufficient.
Therefore, I increased the multiplier from 1.5 to 1.75